aminghadersohi commented on code in PR #44950:
URL: https://github.com/apache/superset/pull/44950#discussion_r4180462817
##########
tests/unit_tests/mcp_service/system/tool/test_get_schema.py:
##########
@@ -643,3 +644,17 @@ async def
test_resource_scope_is_enforced_when_rbac_disabled(self, app, mcp_serv
can_access.assert_not_called()
scope_allows.assert_called_once_with("read", "Chart")
+
+
[email protected]
+async def test_get_schema_chart_datasource_id(mcp_server: Any) -> None:
Review Comment:
Fixed in 107a98a69d131d8c0211aa1a3b479c23cc4d06e9. Moved the datasource_id
discovery test into TestGetSchemaToolViaClient, matching the file's existing
class grouping. No production behavior changed. Validation: system unit suite
161 passed; pre-commit passed on the touched file.
##########
tests/unit_tests/mcp_service/system/tool/test_get_schema.py:
##########
@@ -643,3 +644,17 @@ async def
test_resource_scope_is_enforced_when_rbac_disabled(self, app, mcp_serv
can_access.assert_not_called()
scope_allows.assert_called_once_with("read", "Chart")
+
+
[email protected]
+async def test_get_schema_chart_datasource_id(mcp_server: Any) -> None:
+ """Chart discovery advertises the supported dataset ID operators."""
+ with patch.object(
+ get_schema_module, "user_can_view_data_model_metadata",
return_value=True
+ ):
Review Comment:
Fixed in 107a98a69d131d8c0211aa1a3b479c23cc4d06e9. Removed the duplicate
permission patch; the module's autouse allow_data_model_metadata fixture
already supplies the identical True return value. Validation: system unit suite
161 passed; pre-commit passed on the touched file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
