sadpandajoe commented on code in PR #44550:
URL: https://github.com/apache/superset/pull/44550#discussion_r4186903925
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts:
##########
@@ -581,17 +607,18 @@ export function sortRows(
sortKey = value;
}
if (
- xAxisSortSeries === SortSeriesType.Name ||
- typeof value !== 'number'
+ aggregation === SortSeriesType.Name ||
+ typeof value !== 'number' ||
+ (sumOfColumns && !sumOfColumns.has(key))
Review Comment:
Descending metric sorting puts categories whose selected metric is entirely
NULL ahead of measured categories, while the ungrouped sort keeps them last, so
adding a dimension changes the order from 10/5/NULL to NULL/10/5. Could missing
sort values stay last in both directions, with a descending null-row regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
