rusackas commented on code in PR #44550:
URL: https://github.com/apache/superset/pull/44550#discussion_r4202182891
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts:
##########
@@ -581,17 +607,18 @@ export function sortRows(
sortKey = value;
}
if (
- xAxisSortSeries === SortSeriesType.Name ||
- typeof value !== 'number'
+ aggregation === SortSeriesType.Name ||
+ typeof value !== 'number' ||
+ (sumOfColumns && !sumOfColumns.has(key))
Review Comment:
Fixed in d2558f7. Rows whose sort columns are all NULL now stay last in both
directions, with a descending regression in `series.test.ts`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
