eschutho commented on PR #43896:
URL: https://github.com/apache/superset/pull/43896#issuecomment-6001087736
@rusackas I've rebased onto the latest master to pick up the upstream mypy
fix in `importers/v1/utils.py` (#44932). The rebase changed the commit SHAs, so
here's where your feedback now lives:
- **Form read in the fallback** (blocking): fixed in 17d2b14b87 (was
6eba8b31d4). `request.form.get("guest_token")` has its own guard and fails
closed (redacts) on *any* exception. That covers werkzeug's
`RequestEntityTooLarge`/`ClientDisconnected`, and also exceptions raised by the
WSGI server's input stream, such as gunicorn's `ParseException` subclasses for
a malformed chunked trailer, which aren't `OSError`s. Tests use a body with no
token and cover both a real werkzeug 413 and a server stream that raises a
plain `Exception`.
- **`side_effect` nit**: fixed in e44af26edb (was 197954e969). The test uses
a single raising `side_effect` and asserts exactly one lookup.
Could you take another look when you have a moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
