eschutho commented on PR #43896: URL: https://github.com/apache/superset/pull/43896#issuecomment-6067038563
I've gone through the automated review comments from the last round: - **codeant: `send_file` can raise other filesystem errors**: a real gap, fixed in 13c09837e8. The last-resort handler now catches `OSError` and falls back to JSON. - **bito: duplicated `send_file` fallback across four handlers**: handled by that same fix rather than a new shared helper. A sibling handler whose `send_file` raises is routed to the last-resort handler, which now always returns a SIP-40 body. - **bito: duplicated guest-token detection**: left as is on purpose. The reasoning is in the thread: the authentication-path read may raise, but this fallback must not. - **bito: type hints on test locals**: not changed. `test_error_handling.py` doesn't annotate locals anywhere (0 of ~47), and mypy infers these. @rusackas, your review predates the fixes for your feedback and this round. Could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
