SBIN2010 commented on code in PR #44907:
URL: https://github.com/apache/superset/pull/44907#discussion_r4189204654
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/consts.ts:
##########
@@ -45,6 +45,13 @@ export const FILTER_CONDITION_BODY_INDEX = {
export const ROW_NUMBER_COL_ID = '__row_number__';
+// Expand and view controls inside a JSON cell. A click on them skips
+// cross-filtering and row selection.
+export const JSON_CELL_ACTION_SELECTOR = '[data-json-cell-action]';
+
+// The control that opens the JSON dialog. Enter on the focused cell clicks it.
+export const JSON_CELL_OPEN_SELECTOR = '[data-test="json-cell-open"]';
Review Comment:
Good catch. The selector no longer relies on `data-test`: that attribute is
stripped out in the bundled package, so `Enter` wasn't finding anything. The
dialog button is now marked with `data-json-cell-open`, just as the other JSON
buttons have their own markers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
