SBIN2010 commented on code in PR #44907: URL: https://github.com/apache/superset/pull/44907#discussion_r4189212398
########## superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/isJsonCellActionTarget.ts: ########## @@ -0,0 +1,55 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { JSON_CELL_ACTION_SELECTOR, JSON_CELL_OPEN_SELECTOR } from '../consts'; + +export function isJsonCellActionTarget(target: EventTarget | null): boolean { + return ( + target instanceof Element && + target.closest(JSON_CELL_ACTION_SELECTOR) !== null + ); +} + +/** Enter on a focused JSON cell opens the dialog. The grid keeps Tab on cells. */ +export function openJsonDialogOnEnter( + nativeEvent: Event | null | undefined, +): boolean { + if ( + !nativeEvent || + !('key' in nativeEvent) || + nativeEvent.key !== 'Enter' || + ('ctrlKey' in nativeEvent && nativeEvent.ctrlKey) || + ('metaKey' in nativeEvent && nativeEvent.metaKey) || + ('altKey' in nativeEvent && nativeEvent.altKey) + ) { + return false; + } + const { target } = nativeEvent; + if (!(target instanceof Element)) { + return false; Review Comment: Good catch. If the focus is already on the arrow or the dialog button, the Enter key is no longer intercepted. The arrow collapses and expands the JSON, while the button opens the dialog. Pressing Enter on the cell itself still opens the dialog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
