FrancescoCastaldi commented on PR #43695:
URL: https://github.com/apache/superset/pull/43695#issuecomment-6004522449
Updated in commit `6288794ccc`:
1. **Parseable connection examples (`parseable.py`)**:
- Retained
`parseable+https://admin:[email protected]:443/ingress-nginx` for the
demo endpoint on port 443, preserving TLS for HTTPS listeners while keeping
`parseable+http://` and default port 8000 for the standard template.
- Added explicit assertion in `test_parseable.py`.
2. **AST engine spec test fixtures (`test_lint_metadata.py`)**:
- Renamed test fixture classes to `TypedInlineBaseEngineSpec` and
`DeclThenAssignBaseEngineSpec` (using the `*BaseEngineSpec` suffix).
- Both fixtures are now subject to the base class filter in
`lint_metadata.py`, ensuring that inline initialized annotations and
declaration-then-assignment patterns prevent skipping and protect engine
discovery.
3. **Validation**:
- `python -m pytest tests/unit_tests/db_engine_specs/test_parseable.py
tests/unit_tests/db_engine_specs/test_lint_metadata.py`: 17/17 passed.
- `python superset/db_engine_specs/lint_metadata.py --strict`: 80/80
specs complete, exit code 0.
- `ruff check` and `ruff format --check`: clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
