codeant-ai-for-open-source[bot] commented on code in PR #45036:
URL: https://github.com/apache/superset/pull/45036#discussion_r4201124725
##########
superset/models/dashboard.py:
##########
@@ -98,23 +107,56 @@ def copy_dashboard(_mapper: Mapper, _connection:
Connection, target: Dashboard)
json_metadata=template.json_metadata,
slices=template.slices,
editors=editors,
- # Resolved from the in-memory collection: this runs in ``after_insert``
- # for the user, before their ``ab_user_group`` rows are written.
viewers=get_default_viewers_for_groups(
list(getattr(new_user, "groups", []) or [])
),
Review Comment:
**Suggestion:** When a user is inserted with groups assigned in memory, this
reloaded user has no persisted group links yet, so the copied dashboard omits
its group viewers.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incorrect
variable usage`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9ff96c497d864fbcbc86d4954e23d040&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9ff96c497d864fbcbc86d4954e23d040&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/models/dashboard.py
**Line:** 110:112
**Comment:**
*Incorrect Variable Usage: When a user is inserted with groups assigned
in memory, this reloaded user has no persisted group links yet, so the copied
dashboard omits its group viewers.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45036&comment_hash=21b67a315c139958d42e81893b1466e7e93f1544dceb85473da8354ae64d69bf&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45036&comment_hash=21b67a315c139958d42e81893b1466e7e93f1544dceb85473da8354ae64d69bf&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
