codeant-ai-for-open-source[bot] commented on code in PR #45036:
URL: https://github.com/apache/superset/pull/45036#discussion_r4216620340
##########
superset/models/dashboard.py:
##########
@@ -98,23 +107,56 @@ def copy_dashboard(_mapper: Mapper, _connection:
Connection, target: Dashboard)
json_metadata=template.json_metadata,
slices=template.slices,
editors=editors,
- # Resolved from the in-memory collection: this runs in ``after_insert``
- # for the user, before their ``ab_user_group`` rows are written.
viewers=get_default_viewers_for_groups(
list(getattr(new_user, "groups", []) or [])
),
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `1c9308e`.
The dashboard copy now derives group viewers from `target.groups` directly
instead of reloading the user and relying on persisted group links.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
