mikebridge commented on code in PR #44899:
URL: https://github.com/apache/superset/pull/44899#discussion_r4201824649
##########
tests/unit_tests/queries/query_object_test.py:
##########
@@ -90,6 +91,19 @@ def test_default_query_object_to_dict():
}
[email protected]("clause", ["where", "having"])
+def test_semantic_view_rejects_custom_sql_extras(clause: str) -> None:
+ """Unsupported SQL clauses fail without SQLA database state."""
+ view: SemanticView = SemanticView(name="Orders")
+ view.__dict__["implementation"] = MagicMock()
Review Comment:
The test this pointed at was rewritten in cf761e5611: it now installs a
`PropertyMock` that raises if `SemanticView.implementation` is accessed, to
prove the SQL-extras rejection runs before the provider is resolved. So the
`__dict__` stub is gone from this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
