mikebridge commented on PR #44899: URL: https://github.com/apache/superset/pull/44899#issuecomment-6028212177
@aminghadersohi thanks, agreed on both bot threads. One follow-up since your pass: cf761e5611 moved the WHERE/HAVING rejection to the start of `QueryObject.validate()`, so it now runs before the semantic view's provider is resolved, not only before the mapper. The test pins that with a mock that fails if the provider is touched first. The PR description notes the one remaining ordering limit: the chart-data context builder can still read the view's column metadata before validation, though no query reaches the provider. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
