aminghadersohi commented on code in PR #44909:
URL: https://github.com/apache/superset/pull/44909#discussion_r4202566497
##########
superset-frontend/packages/superset-ui-core/test/query/buildQueryContext.test.ts:
##########
@@ -19,6 +19,41 @@
import { buildQueryContext, VizType } from '@superset-ui/core';
import * as queryModule from '../../src/query/normalizeTimeColumn';
+test('semantic queries omit a positive limit without final series columns', ()
=> {
+ const formData = {
+ datasource: '5__semantic_view',
+ viz_type: VizType.Table,
+ metrics: ['revenue'],
+ series_limit: 2,
+ };
+ const context = buildQueryContext(formData, baseQuery => [
+ { ...baseQuery, series_columns: [] },
+ ]);
+
+ expect(context.queries[0].series_limit).toBe(0);
+ expect(context.form_data?.series_limit).toBe(2);
+ expect(
+ buildQueryContext({ ...formData, datasource: '5__table' }, baseQuery => [
+ { ...baseQuery, series_columns: [] },
+ ]).queries[0].series_limit,
+ ).toBe(2);
+ expect(
+ buildQueryContext(formData, baseQuery => [
+ { ...baseQuery, series_columns: ['product'] },
+ ]).queries[0].series_limit,
+ ).toBe(2);
+ expect(
+ buildQueryContext(formData, baseQuery => [
+ { ...baseQuery, is_timeseries: true, metrics: [], series_columns: [] },
Review Comment:
This case also has empty `columns`, so it still passes if the `metrics`
conjunct is dropped from `hasInferredSeriesColumns`; giving it columns makes it
pin that conjunct.
```suggestion
{
...baseQuery,
is_timeseries: true,
metrics: [],
columns: ['product'],
series_columns: [],
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
