mikebridge commented on code in PR #44909: URL: https://github.com/apache/superset/pull/44909#discussion_r4213041928
########## docs/docs/using-superset/exploring-data.mdx: ########## @@ -113,6 +113,11 @@ chart requires access to its datasource; overwriting an existing chart also requires chart edit permission. SQL Lab queries must first be saved as datasets before they can be used as persistent chart datasources. +For a semantic view, Pivot Table hides **Series limit** because it has no series +columns to limit. Existing Pivot Table charts with a saved Series limit still +run without applying that limit. Programmatic semantic-view queries with a +positive `series_limit` and no `series_columns` run without a series limit. Review Comment: Good catch — the docs now say that a timeseries query with metrics and at least one `columns` value infers series columns and keeps the limit. The no-limit case is scoped to queries without effective series columns. Updated in [8b0a495e](https://github.com/apache/superset/commit/8b0a495e60b5f58cb7d10f55aa56f3e9f9bb219b). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
