FrancescoCastaldi commented on PR #45039: URL: https://github.com/apache/superset/pull/45039#issuecomment-6056203416
Thanks for the detailed review @sadpandajoe. I have addressed all points in commit d94a14d351: 1. **Store configuration lookup**: Updated `useSelector` in `RefreshFrequencySelect.tsx` to check `state.common?.conf?.DASHBOARD_AUTO_REFRESH_INTERVALS` first before falling back to `state.dashboardInfo?.common?.conf?.DASHBOARD_AUTO_REFRESH_INTERVALS`. This ensures the Properties modal correctly displays configured intervals on dashboard list and home pages as well. 2. **Custom interval selection with 1-second preset**: Added `lastEmittedCustomValueRef` to track locally emitted custom intervals. When the controlled parent feeds back the value emitted upon selecting Custom or typing a custom duration, the synchronization effect skips reverting to the preset, keeping the Custom radio selected and the input enabled. Also preserved custom values across preset toggling. 3. **Formatter compliance**: Formatted both source and test files using `oxfmt --write` with `arrowParens: "avoid"`, ensuring single-parameter arrow functions use the canonical style (`option =>`, `e =>`). 4. **Unit test coverage**: Added test cases covering the top-level `state.common.conf` store shape, controlled parent interaction when configured intervals include a 1-second preset, and custom value persistence across selections (all 17 unit tests passing). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
