FrancescoCastaldi commented on code in PR #45039:
URL: https://github.com/apache/superset/pull/45039#discussion_r4217327343
##########
superset-frontend/src/dashboard/components/RefreshFrequency/RefreshFrequencySelect.tsx:
##########
@@ -120,11 +220,13 @@ export const RefreshFrequencySelect = ({
if (selectedValue === -1) {
// Custom selected - use current custom value or minimum
const numValue = parseInt(customValue, 10) || MINIMUM_REFRESH_INTERVAL;
Review Comment:
Clamped the draft value in handleRadioChange so that when reselecting
Custom, it only reuses drafts that parse to at least MINIMUM_REFRESH_INTERVAL,
falling back to MINIMUM_REFRESH_INTERVAL (and updating customValue) otherwise.
Added a controlled regression test covering the -5 -> preset -> Custom sequence
in RefreshFrequencySelect.test.tsx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
