aminghadersohi commented on code in PR #45084:
URL: https://github.com/apache/superset/pull/45084#discussion_r4217628034
##########
superset/mcp_service/server.py:
##########
@@ -1075,6 +1128,13 @@ def run_server(
tool_search_config = MCP_TOOL_SEARCH_CONFIG
if tool_search_config.get("enabled", False):
_apply_tool_search_transform(mcp_instance, tool_search_config)
+ else:
+ _apply_compact_tool_list_transform(
+ mcp_instance,
+ factory_flask_app.config.get(
+ "MCP_NATIVE_TOOL_LIST_CONFIG", MCP_NATIVE_TOOL_LIST_CONFIG
+ ),
+ )
Review Comment:
Valid finding. Fixed in b2558a6d715a772643dfb8c1a6022e8d4c30f264: factory
startup reads MCP_TOOL_SEARCH_CONFIG from the Flask app, falling back to the
module default, so disabling search selects the native listing and honors
MCP_NATIVE_TOOL_LIST_CONFIG. Regression coverage exercises default and factory
startup with absent settings, native mode, and compact native mode. The new
factory/native cases failed before the fix; all 53 server/native-surface tests
pass after it. Pre-commit passes for staged files and all branch-changed files,
including mypy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
