geido commented on code in PR #45035:
URL: https://github.com/apache/superset/pull/45035#discussion_r4218557943
##########
.github/workflows/docker.yml:
##########
@@ -280,10 +291,15 @@ jobs:
docker-build:
name: docker-build
needs: [setup_matrix, changes]
+ # A push build exists to publish images. Without the Docker Hub
+ # credentials (e.g. on a fork or mirror) it can publish nothing, so it
+ # is skipped there; pull_request builds, which only validate that the
+ # images build, run everywhere.
if: >-
- needs.changes.outputs.python == 'true' ||
- needs.changes.outputs.frontend == 'true' ||
- needs.changes.outputs.docker == 'true'
+ (github.event_name != 'push' || needs.setup_matrix.outputs.has-secrets)
&&
Review Comment:
Quick question: version-branch pushes use `--load`, so they can still
validate the image without Docker Hub credentials. Is skipping those builds on
mirrors intentional? If not, could we limit this check to `master` pushes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
