aminghadersohi commented on code in PR #45084:
URL: https://github.com/apache/superset/pull/45084#discussion_r4224641691
##########
superset/mcp_service/server.py:
##########
@@ -549,10 +559,7 @@ def _serializer(tools: Sequence[Any]) -> list[dict[str,
Any]]:
results = _serialize_tools_without_output_schema(tools)
for tool, data in zip(tools, results, strict=True):
if desc := data.get("description"):
- instructions = _request_instructions(tool)
- data["description"] = _truncate_description(
- desc, max(0, max_desc - len(instructions))
- )
+ data["description"] = _bounded_description(tool, desc,
max_desc)
Review Comment:
Agreed. I removed the deduction in both search serializers in
796ff50fccf4c95ea8409d889e4bc03369e63bb2; instructions remain intact in
inputSchema/parameters_hint. I added list_datasets regressions for both modes
at 150/250/300 characters, preserving the list_metrics/get_table steer. The
affected MCP tests and pre-commit (including mypy) pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
