mikebridge commented on PR #45099: URL: https://github.com/apache/superset/pull/45099#issuecomment-6070195237
@fitzee thanks, good catches, all addressed in `444c6c8003`: - Embedded paginated JSON now uses the `SQL_MAX_ROW` ceiling (including zero/unset limits), while attachments keep their export ceiling. - Unusable params preserve the saved `form_data`. - The Slack truncation branches render `truncated_df`, and the test now checks actual message size. - The GET URL is built only for the fallback. - The docs explain why stale settings or the embedded ceiling can make the TEXT body differ from attachments. Red-first tests reproduced both main issues and Slack's 10,987-character output; the affected suites pass 466 tests. A row ceiling isn't a byte guarantee, so the docs recommend attachments for large or wide reports. Could we leave retry-policy alignment and a real endpoint integration test as follow-ups? The embedded GET didn't retry before either, and the current tests cover payload, transport and conversion rather than a live endpoint roundtrip. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
