aminghadersohi commented on code in PR #45099:
URL: https://github.com/apache/superset/pull/45099#discussion_r4227015701


##########
superset/commands/report/execute.py:
##########
@@ -1165,6 +1175,11 @@ def _get_chart_data_request_payload(
 
             if form_data.get("server_pagination"):
                 row_limit = form_data.get("row_limit") or 0

Review Comment:
   Verified at `4c993e6f97`: `None`/`""`/invalid/negative/NaN/inf/huge values 
parse to 0 and take the `SQL_MAX_ROW` cap, `"15.0"` requests 15, and each 
helper mutant fails the new cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to