mikebridge commented on code in PR #45106:
URL: https://github.com/apache/superset/pull/45106#discussion_r4226804759
##########
superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.test.tsx:
##########
@@ -584,7 +584,11 @@ test('should call exportChart when exportCSV is clicked',
async () => {
);
fireEvent.click(getByRole('button', { name: 'More Options' }));
fireEvent.mouseOver(getByRole('menuitem', { name: 'Download right' }));
- const exportAction = await findByText('Export to .CSV');
+ const exportAction = await findByText(
+ 'Export to .CSV',
+ {},
+ { timeout: 5000 },
Review Comment:
Thanks, agreed. All four Download-submenu tests now use the same bounded
five-second wait, including `Export to full .CSV`, `Export to Excel` and
`Export to full Excel` (30c820b8c2). The click and export-call assertions are
unchanged.
Both affected test files passed five consecutive local runs (78 passed, 2
existing skips each), and the frontend hooks passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
