mikebridge commented on PR #45034: URL: https://github.com/apache/superset/pull/45034#issuecomment-6074705236
@rebenitez1802 following up on your [first review](https://github.com/apache/superset/pull/45034#pullrequestreview-5461523306), thanks for the careful read. Addressed in `343af81c68`, `31b365ded3` and `92b1a43667` (merged with master at `91c62a92b5`): - **Isolation note:** the guidance lives in `UPDATING.md` (Next section). It explains that MySQL/MariaDB permission cleanup requires READ COMMITTED, and that other or unverifiable isolation levels retain `datasource_access` records, which can accumulate as orphans. Superset supplies that default only for the `mysql`/`postgresql` URI backends when no isolation level is configured; `mariadb://` and `mariadb+pymysql://` need `SQLALCHEMY_ENGINE_OPTIONS = {"isolation_level": "READ COMMITTED"}` set explicitly. I dropped the duplicate `config.py` comment so the guidance has a single home. - **Phase ordering:** the purge call site in `purge_policy.py` now notes that POST_DELETE runs after the dataset row is gone, so the ownership probe cannot match the dataset being purged. - **Per-delete lock:** unchanged. It serializes competing cleanup decisions and is held until the transaction completes. My reply on your second review covers the cost question. Focused security, purge and soft-delete tests pass on the merged head, along with the changed-file hooks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
