codeant-ai-for-open-source[bot] commented on code in PR #45126:
URL: https://github.com/apache/superset/pull/45126#discussion_r4232371703
##########
superset/semantic_layers/models.py:
##########
@@ -388,6 +389,20 @@ def get_query_result(self, query_object: QueryObject) ->
QueryResult:
security_manager.raise_for_unsupported_guest_rls(self)
result: QueryResult = get_results(query_object)
if query_object.post_processing and not result.df.empty:
+ # Nullable integer metrics arrive as exact Python ints;
calculations
+ # need numbers, as for SQL datasets. Plain chart data stays exact.
+ metric_names: list[str] = query_object.metric_names
+ df_columns_to_num(
+ result.df,
+ {
+ *metric_names,
+ *(
+ TIME_COMPARISON.join([metric, offset])
+ for metric in metric_names
+ for offset in query_object.time_offsets
+ ),
+ },
+ )
Review Comment:
**Suggestion:** `df_columns_to_num` skips nullable integer dimensions, which
are object-typed after Arrow conversion; contribution then rejects an
explicitly selected dimension as non-numeric.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Type error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=8dc37d9581434053a536850a1155cb73&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=8dc37d9581434053a536850a1155cb73&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/semantic_layers/models.py
**Line:** 394:405
**Comment:**
*Type Error: `df_columns_to_num` skips nullable integer dimensions,
which are object-typed after Arrow conversion; contribution then rejects an
explicitly selected dimension as non-numeric.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45126&comment_hash=0e7a999f648e9b0805c22da6dff0281ad0983f3f0629af23e930b4c937c21d54&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45126&comment_hash=0e7a999f648e9b0805c22da6dff0281ad0983f3f0629af23e930b4c937c21d54&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
