mikebridge commented on code in PR #45126:
URL: https://github.com/apache/superset/pull/45126#discussion_r4235598556
##########
superset/semantic_layers/mapper.py:
##########
@@ -192,7 +194,9 @@ def get_results(query_object: QueryObject) -> QueryResult:
# Add this query's requests to the collection
all_requests.extend(result.requests)
- offset_df = stringify_extension_columns(result.results).to_pandas()
+ offset_df = stringify_extension_columns(result.results).to_pandas(
+ integer_object_nulls=True,
+ )
Review Comment:
Good catch — the left join was upcasting an exact int64 offset metric when
the prior period had no row for a main-period category. I applied your cast
before the merge.
- Added a chart-data regression with main categories A/B and an offset row
for A only; before the fix, `9007199254740993` returned as
`9007199254740992.0`, and it now returns as the exact string.
- All 18 precision cases and the changed-file hooks pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
