mikebridge commented on code in PR #45133:
URL: https://github.com/apache/superset/pull/45133#discussion_r4235501446
##########
superset/semantic_layers/models.py:
##########
@@ -786,9 +786,11 @@ def result_cache_discriminator(self) -> tuple[str, str] |
None:
def get_extra_cache_keys(self, query_obj: QueryObjectDict) ->
list[Hashable]:
discriminator: tuple[str, str] | None = self.result_cache_discriminator
- if discriminator is None:
- return []
- return [("semantic-result-version", *discriminator)]
+ # Separate cached pre-normalization results during rolling deployments.
+ keys: list[Hashable] = ["semantic-null-filters-v1"]
+ if discriminator is not None:
+ keys.append(("semantic-result-version", *discriminator))
+ return keys
Review Comment:
Not changing here. Master already omits `metadata_cache_token` from
`get_extra_cache_keys`, and this PR only adds the null-filter version key.
Metadata invalidation in result cache keys is handled in #45100, which keys on
the host `metadata_generation` (the SDK view token is just the provider echo).
##########
superset-core/src/superset_core/semantic_layers/types.py:
##########
@@ -231,7 +257,7 @@ class SemanticQuery:
metrics: list[Metric]
dimensions: list[Dimension]
- filters: set[Filter] | None = None
+ filters: set[FilterExpression] | None = None
Review Comment:
No positional shift. `filters` is already the third field of `SemanticQuery`
on master (metrics, dimensions, filters, order, ...). This PR only widens its
type to `set[FilterExpression]`; field order is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
