mikebridge commented on code in PR #45133:
URL: https://github.com/apache/superset/pull/45133#discussion_r4236466885
##########
superset/semantic_layers/models.py:
##########
@@ -786,9 +786,11 @@ def result_cache_discriminator(self) -> tuple[str, str] |
None:
def get_extra_cache_keys(self, query_obj: QueryObjectDict) ->
list[Hashable]:
discriminator: tuple[str, str] | None = self.result_cache_discriminator
- if discriminator is None:
- return []
- return [("semantic-result-version", *discriminator)]
+ # Separate cached pre-normalization results during rolling deployments.
+ keys: list[Hashable] = ["semantic-null-filters-v1"]
Review Comment:
Fixed in d1511b0ca6f55102e137b7b0851a596509a852cf. The annotation context
now always includes the NULL-protocol marker, so upgraded workers cannot reuse
pre-fix parent entries, including for semantic sources reached through saved
query contexts. The real-Slice regression failed before the change and passes
with it. UPDATING notes the one-time cold cache for chart-backed annotations;
SQL-only annotation parents also receive the version bump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
