rusackas opened a new pull request, #45202: URL: https://github.com/apache/superset/pull/45202
### SUMMARY bito's post-approval review on #44355 flagged that `coerce_boolean_for_sql` and `use_equality_for_boolean_filters` were defined identically three times (`DatabricksBaseEngineSpec`, `DatabricksHiveEngineSpec`, `SparkEngineSpec`) across `databricks.py` and `spark.py`. This hoists the shared logic into a `DatabricksBooleanEqualityMixin` in `hive.py` and mixes it into all three classes, so a future change to the coercion (e.g. a third keyword) can't drift across copies. No behavior change: the mixin's `coerce_boolean_for_sql`/`use_equality_for_boolean_filters` are byte-for-byte what each class defined on its own before. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A, backend-only refactor. ### TESTING INSTRUCTIONS - `pytest tests/unit_tests/db_engine_specs/` — 2208 passed, 10 skipped (no changes needed; existing `test_databricks.py` coverage for `coerce_boolean_for_sql`/`use_equality_for_boolean_filters` exercises all three specs through the mixin). - `pre-commit run --files superset/db_engine_specs/databricks.py superset/db_engine_specs/spark.py superset/db_engine_specs/hive.py` — all green (mypy, ruff, pylint, engine-spec metadata validation). ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
