sadpandajoe commented on code in PR #45202:
URL: https://github.com/apache/superset/pull/45202#discussion_r4254954114
##########
superset/db_engine_specs/spark.py:
##########
@@ -16,14 +16,11 @@
# under the License.
from __future__ import annotations
-from typing import Any
-
-from sqlalchemy import false, true
from sqlalchemy.dialects import registry
from superset.constants import TimeGrain
from superset.db_engine_specs.base import DatabaseCategory
-from superset.db_engine_specs.hive import HiveEngineSpec
+from superset.db_engine_specs.hive import SparkSqlBooleanEqualityMixin,
HiveEngineSpec
Review Comment:
Same import-order failure here: `HiveEngineSpec` should come before
`SparkSqlBooleanEqualityMixin`, otherwise ruff I001 keeps `pre-commit
(current)` failing.
```suggestion
from superset.db_engine_specs.hive import HiveEngineSpec,
SparkSqlBooleanEqualityMixin
```
##########
superset/db_engine_specs/databricks.py:
##########
@@ -40,7 +40,7 @@
BasicParametersMixin,
DatabaseCategory,
)
-from superset.db_engine_specs.hive import HiveEngineSpec
+from superset.db_engine_specs.hive import SparkSqlBooleanEqualityMixin,
HiveEngineSpec
Review Comment:
After the rename, `SparkSqlBooleanEqualityMixin` sorts after
`HiveEngineSpec`, so ruff's import sorting (I001) rejects this line and the
`pre-commit (current)` job is red on this head. `spark.py` has the same import
order. Could you reorder the names?
```suggestion
from superset.db_engine_specs.hive import HiveEngineSpec,
SparkSqlBooleanEqualityMixin
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
