FrancescoCastaldi commented on PR #43697: URL: https://github.com/apache/superset/pull/43697#issuecomment-6114305107
Thanks @rusackas for following up. I have reframed this PR to focus exclusively on the database engine spec unit test additions, and cleanly removed the superseded `manager.py` changes and associated tests (which landed via #43577). The PR now covers dedicated unit test suites for 7 engine specs: - `CockroachDB`: properties and metadata specification - `MotherDuck`: properties and metadata specification - `Amazon DynamoDB`: properties, metadata, `epoch_to_dttm`, and time grain expressions - `Firebolt`: properties, metadata, and time grain expressions using `TimeGrain` - `Google Sheets`: properties and metadata specification (with `google-sheets.svg`) - `Azure Synapse`: properties and metadata specification - `OceanBase`: properties, metadata, and full `test_get_column_spec` verification All 7 test files compile cleanly and the branch is ready for your review whenever you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
