FrancescoCastaldi opened a new pull request, #45205:
URL: https://github.com/apache/superset/pull/45205
### Summary
This PR adds and expands unit test suites for database engine specs lacking
dedicated coverage (`CockroachDB`, `MotherDuck`, `Amazon DynamoDB`, `Firebolt`,
`Google Sheets`, `Azure Synapse`, and `OceanBase`).
As discussed with @rusackas in #43697, this fresh PR isolates the test
suites onto a clean branch branched directly from current `master`, leaving
behind the superseded security manager scalar-control fix that previously
landed via #43577.
### Key Changes
1. **CockroachDB (`tests/unit_tests/db_engine_specs/test_crdb.py`)**:
- Added unit tests for engine properties (`engine`, `engine_name`,
subclass of `PostgresEngineSpec`).
- Added unit tests for metadata specification (`description`, `logo`,
`pypi_packages`, `default_port`).
2. **MotherDuck (`tests/unit_tests/db_engine_specs/test_duckdb.py`)**:
- Added unit tests for engine properties (`engine`, `engine_name`,
subclass of `DuckDBEngineSpec`).
- Added unit tests for metadata specification (`description`, `logo`,
`pypi_packages`).
3. **Amazon DynamoDB (`tests/unit_tests/db_engine_specs/test_dynamodb.py`)**:
- Added unit tests for engine properties and metadata specification.
- Added unit tests for `epoch_to_dttm` and time grain expressions
(`PT1S`, `PT1M`, `PT1H`, `P1D`, `P1M`, `P1Y`).
4. **Firebolt (`tests/unit_tests/db_engine_specs/test_firebolt.py`)**:
- Added unit tests for engine properties and metadata specification.
- Added unit tests for time grain expressions using `TimeGrain` constants
(`SECOND`, `MINUTE`, `HOUR`, `DAY`, `WEEK`, `MONTH`, `QUARTER`, `YEAR`).
5. **Google Sheets (`tests/unit_tests/db_engine_specs/test_gsheets.py`)**:
- Added unit tests for engine properties (`engine`, `engine_name`,
subclass of `ShillelaghEngineSpec`).
- Added unit tests for metadata specification (`description`, `logo`,
`pypi_packages`).
6. **Azure Synapse (`tests/unit_tests/db_engine_specs/test_mssql.py`)**:
- Added unit tests for engine properties (`engine`, `engine_name`,
`default_driver`, subclass of `MssqlEngineSpec`).
- Added unit tests for metadata specification (`description`, `logo`,
`pypi_packages`).
7. **OceanBase (`tests/unit_tests/db_engine_specs/test_oceanbase.py`)**:
- Retained full `test_get_column_spec` coverage.
- Added unit tests for engine properties (`engine`, `engine_name`,
`default_driver`, `max_column_name_length`, subclass of `MySQLEngineSpec`).
- Added unit tests for metadata specification (`description`, `logo`,
`homepage_url`).
### Testing Instructions
- Run `pytest tests/unit_tests/db_engine_specs/test_crdb.py`
- Run `pytest tests/unit_tests/db_engine_specs/test_duckdb.py`
- Run `pytest tests/unit_tests/db_engine_specs/test_dynamodb.py`
- Run `pytest tests/unit_tests/db_engine_specs/test_firebolt.py`
- Run `pytest tests/unit_tests/db_engine_specs/test_gsheets.py`
- Run `pytest tests/unit_tests/db_engine_specs/test_mssql.py`
- Run `pytest tests/unit_tests/db_engine_specs/test_oceanbase.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
