FrancescoCastaldi commented on PR #45051: URL: https://github.com/apache/superset/pull/45051#issuecomment-6114722109
Hi @sadpandajoe @rusackas, Checking in on PR #45051 for issue #45050. The core contract is locked in by unit tests asserting that `forceRender` is never passed to `DropdownContainer` (`expect(latestProps().forceRender).toBeFalsy()`), while `FilterValue.tsx` initializes `inViewFirstTime` directly to `inView || isRequiredFirst` so that required-first filters request data on mount without requiring hidden popover reverse portals to force render. All unit and integration tests pass cleanly. Whenever you have a chance, please take a look for re-review. Thank you! @coderabbitai review @bito-code-review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
