FrancescoCastaldi commented on PR #45051:
URL: https://github.com/apache/superset/pull/45051#issuecomment-6133132536
Thanks for the review @sadpandajoe! I have pushed commit `f674ce81cb`
updating the real `DropdownContainer` regression test in
`FilterControls.overflow.test.tsx`:
1. Starts without the cross-filter chip (`dataMask: {}`) using a real Redux
store (`createStore(..., reducerIndex)`).
2. Forces overflow geometry via `getBoundingClientRect` (`450px` container
width, `200px` per child) so `Account` and `Date range` fit in the main row
while `Flow` overflows and renders the closed `More filters` popover trigger
(`dropdown-container-btn`).
3. Verifies that while `More filters` is closed, `dropdown-content` is not
force-rendered into hidden DOM (which fails immediately if
`forceRender={hasRequiredFirst}` is re-added).
4. Dispatches `updateDataMask` to add the cross-filter chip while `More
filters` is closed, then opens `More filters` and verifies all controls
(`Products Sold By Product Line`, `Account`, `Date range`, and `Flow`) are
reachable across the main row and opened popover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
