FrancescoCastaldi commented on PR #43695: URL: https://github.com/apache/superset/pull/43695#issuecomment-6114721132
Hi @sadpandajoe @rusackas @villebro, Pushed commits `1ad6d80546`, `17b804d2e6`, and `3b708447d1` completing all remaining metadata points: 1. IBM i database field: Updated the description in `superset/db_engine_specs/ibmi.py` to specify 'RDB name' matching ODBC driver requirements. 2. ClickHouse Connect docs: Defined an explicit `sqlalchemy_docs_url` on `ClickHouseConnectEngineSpec.metadata` to prevent falling back to the legacy driver link via class inheritance. 3. Databricks dialects: Updated `pypi_packages` on `DatabricksODBCEngineSpec` and `DatabricksPyHiveEngineSpec` to specify `databricks-dbapi[sqlalchemy]` for dialect registration. All 80 database engine specs pass strict AST linter validation (`python superset/db_engine_specs/lint_metadata.py --strict`) with exit code 0. Ready for final merge. @coderabbitai review @bito-code-review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
