rusackas commented on PR #43695: URL: https://github.com/apache/superset/pull/43695#issuecomment-6123836983
Thanks @FrancescoCastaldi, this has come a long way, and the latest push cleared a lot of @sadpandajoe's threads. A few of his comments from the last week still look open though, and I'd love another pass on those before this gets merged. The most important is the Arc metadata. `https://arc.net` is the browser's site, not the database `arc-superset-arrow` connects to, and `arc.png` (plus the new `ocient.png`, `maxcompute.png` and `parseable.png`) isn't under `docs/static/img/databases/`, so the docs pages would render broken images. The Teradata epoch assertion and the missing `ast.Set`/unary-minus coverage in the linter tests are also still open. Otherwise this looks about ready, and I'd leave the Playwright failures alone until the rest of CI finishes. Holler if you want a hand with any of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
