rusackas commented on PR #44183: URL: https://github.com/apache/superset/pull/44183#issuecomment-6123894799
Thanks for picking this up @xzisaak-ai. A few of these tests only check that `dashboard-tags-field` is in the document, so they'd pass whether or not tags are selected or the field is disabled. "allows selecting multiple tags" never opens the selector or checks `onChange`, "shows selected tags" never checks the tag names are rendered, and the loading one never checks the `disabled` state. Could you assert the actual behavior in each (selected values visible, `onChange` called, disabled when `isLoading`)? The PR description also mentions a clear-button test that isn't in the diff, so either add it or drop it from the description. Happy to take another look once those are in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
