rusackas commented on PR #44215: URL: https://github.com/apache/superset/pull/44215#issuecomment-6123901472
@villebro checking back in, holler if we can help move this forward. This still looks like the right fix for #44133. It needs a rebase: #45002, #44993 and #45060 all touched `raise_for_access` in `manager.py` after your last merge, so the new inheritance branches will need to be reconciled with the datasource type/id binding from #45002 in particular. @madhushreeag, the editors-leg `published` issue you flagged was fixed in f8ac8a3137. Could you take another look once the rebase lands, and re-approve if it looks right to you? Happy to take a pass at the conflict resolution myself if you're swamped, just say the word. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
