rusackas commented on PR #44281: URL: https://github.com/apache/superset/pull/44281#issuecomment-6123925042
Thanks @eschutho, this is a nice cleanup, and the pymssql detection fix makes sense. That said, Codeant's thread on Synapse is still open, and it looks legit to me. With `pyodbc` installed the form would build a `mssql+pyodbc://` URI with no `driver` or `odbc_connect` param, which I don't think connects. Should Synapse keep the raw URI box until the form can handle that? Also worth clearing Bito's annotation nit on the new `find_spec` mock while you're in there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
