eschutho commented on PR #44281: URL: https://github.com/apache/superset/pull/44281#issuecomment-6204613217
> Replying to https://github.com/apache/superset/pull/44281#issuecomment-6123925042 Thanks @rusackas, both points are addressed: 1. **Synapse / pyodbc**: Synapse now keeps the raw SQLAlchemy URI box. `AzureSynapseSpec` exposes no parameters schema, and `/available/` only offers the dynamic form when a spec has one, so the form can't build a driverless `mssql+pyodbc://` URI anymore, with pyodbc only or with both drivers. SAP ASE (Sybase), also a `MssqlEngineSpec` subclass on ODBC, opts out the same way. The SQL Server form stays pymssql-only. Details are in the CodeAnt thread. 2. **Bito's nit**: the `find_spec` mock in `test_init.py` is annotated as `MagicMock` (8888033d81). The branch also has fixes from a product acceptance pass: field-level connection errors matching pymssql 2.4's FreeTDS messages (verified against SQL Server 2022), reuse of the stored password when only non-redirecting options like `login_timeout` change, a named-instance hint, keeping the SQL Server URI placeholder and the link back to the form, and "mssql" search in the picker. Could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
