rusackas commented on PR #40919: URL: https://github.com/apache/superset/pull/40919#issuecomment-6123627953
Thanks for working on this @nicob3y. I'd echo what @sadpandajoe asked above. Right now the translated strings seem to feed into the SQL generation and filter matching, so a customized label would change the query logic itself. I think the display label and the underlying sentinel value need to stay separate, with only the label going through `t()`. Could you take a look at the open Bito and CodeAnt threads once that's settled? A few of them (the falsy-zero checks, `removeNulls`, `NULL` vs `<NULL>`) look legit. Needs a rebase too, since GitHub shows conflicts. Holler if you want a hand with any of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
