rusackas commented on PR #43694: URL: https://github.com/apache/superset/pull/43694#issuecomment-6123823971
Thanks @Archita-kale for sticking with this one. The same fix already landed on `master` via #43693 (`fix(postprocessing): preserve NULL index values through pivot() (#43547)`). It has the same `_fill_dimension_column` helper and the same `NULL_STRING` fill on the index columns. It also covers the categorical, datetime and nullable-dtype handling that came out of the review threads here. That's why this branch now conflicts with `master`, and a rebase would just reduce it to the leftover bits. Two things from this branch didn't make it over. One is `timedelta64` handling, which was never part of #43693. The other is the open question from @sadpandajoe about resample needing a `DatetimeIndex` when a null timestamp turns the index into a mixed object Index. If either matters to you, a small follow-up PR against `master` is the cleanest way to carry it. Otherwise I think we can close this in favor of #43693. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
