itzmzn opened a new pull request, #45235: URL: https://github.com/apache/superset/pull/45235
### SUMMARY Save As was updating the original dashboard after creating the copy. The success handler called `saveChartConfiguration`, which used the source dashboard ID still held in Redux. This moves the cross-filter configuration into the copy request and removes that follow-up save. The regression tests cover copying with and without duplicate charts. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No visual changes. Manual verification in a running Superset instance is still pending. ### TESTING INSTRUCTIONS 1. Open an existing dashboard and note its last-modified time and user. 2. Use Save As with "Also copy (duplicate) existing charts" enabled. 3. Check that the copy opens, its charts are duplicated, and the original dashboard's audit fields remain unchanged. 4. Repeat with chart duplication disabled and check that cross-filter scoping is preserved. Automated validation on the reviewed upstream revision: - All 46 tests in `dashboardState.test.ts` passed. - The two new regression cases failed against the original implementation. - Formatting, lint, custom rules, and stylelint passed. - Type checking did not pass because shared-package declarations had not been built. AI assisted with the implementation and automated validation. This is a draft until manual verification and type checking are complete. ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #45218 - [ ] Required feature flags - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
