EnxDev commented on code in PR #45235:
URL: https://github.com/apache/superset/pull/45235#discussion_r4258027713
##########
superset/daos/dashboard.py:
##########
@@ -857,6 +861,8 @@ def copy_dashboard(
]
)
value["meta"]["chartId"] = new_id
+
+ update_cross_filter_scoping({"metadata": metadata},
old_to_new_slice_ids)
Review Comment:
This remaps the config the request carries, but the copy still starts from
`original_dash.params`. So a `/copy/` call with `duplicate_slices` on and no
`chart_configuration` in `json_metadata` keeps the source's entries, keyed by
the source chart ids.
The UI always sends both keys, so not blocking. Seeding them from
`original_dash.params_dict` when they're missing, before this call, would close
it (in a small helper, `copy_dashboard` is already at the C901 limit).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
