rusackas commented on PR #39102: URL: https://github.com/apache/superset/pull/39102#issuecomment-6150318882
Pushed a cleaned-up commit to get this one over the line. @hainenber you were right, that "Dark mode overrides" block really was duplicated verbatim, confirmed it myself pulling the branch. This version has exactly one copy. Also dropped the `Root.js` hunk entirely. It only de-indented a `trackEvent()` call, and `master` has since reformatted that same call differently on its own, so carrying it forward would've just reintroduced worse formatting against current `master` (the branch's history had picked up a lot of merge-master noise along the way too, so I squashed it down to the real net change rather than fighting through that). @hainenber mind another look when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
