codeant-ai-for-open-source[bot] commented on code in PR #45260:
URL: https://github.com/apache/superset/pull/45260#discussion_r4267368468
##########
superset-frontend/src/explore/components/controls/DateFilterControl/components/DateFunctionTooltip.tsx:
##########
@@ -90,6 +90,7 @@ dateunit = (year | month | week)`}</code>
<pre>
<code>{`holiday([string])
holiday([holiday string], [datetime])
+holiday([holiday string], [country name])
Review Comment:
**Suggestion:** The syntax promises a country name, but full names such as
“United Kingdom” are rejected, so users following it receive a `ValueError`.
**Assessment:** 🟠 `Major` · 🔁 `Occurrence: Sometimes` · 🏷️ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=970a834c02bb43ed96757146d65a8111&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=970a834c02bb43ed96757146d65a8111&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/explore/components/controls/DateFilterControl/components/DateFunctionTooltip.tsx
**Line:** 93:93
**Comment:**
*Api Mismatch: The syntax promises a country name, but full names such
as “United Kingdom” are rejected, so users following it receive a `ValueError`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45260&comment_hash=890f92bfb023da625fe9e236db1340128597de3f385a9d5f9bd353e4a61e5289&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45260&comment_hash=890f92bfb023da625fe9e236db1340128597de3f385a9d5f9bd353e4a61e5289&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
