SEPURI-SAI-KRISHNA commented on PR #45260: URL: https://github.com/apache/superset/pull/45260#issuecomment-6162669104
Good catch. The syntax block already said `[country name]` for the three-argument form before this change, and I repeated that wording on the two-argument form. `country_holidays` accepts an ISO code or the holidays package's own registered name, so `UK`, `GB`, `Germany` and `Canada` resolve while `United Kingdom` and `us` do not. The code is the form that works for every supported country, so both syntax lines now say `[country code]`. Accepting full names would need a name-to-code mapping, which is a separate change. What this PR fixes is that an unsupported value returns a 400 naming the country instead of a 500. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
