FrancescoCastaldi commented on PR #43695:
URL: https://github.com/apache/superset/pull/43695#issuecomment-6163255507
**Follow-up updates (@sadpandajoe) - addressed in commit
6209589fc6629c0125d5bb26fc7c5e5b07c2c86c**
1. **Omit forced default catalog fallback (thread 4260350930)**:
Removed `default_catalog = "hive_metastore"` from
`DatabricksNativeEngineSpec` and dropped the fallback in
`adjust_engine_params`. When unconfigured, catalog remains unset so the server
default catalog applies naturally, preventing handshake failures on servers
without multi-catalog support and preserving discovery in
`get_default_catalog()`.
2. **Skip URI-database schema fallback on catalog override (thread
4260350941)**:
Updated `adjust_engine_params` so `uri.database` is used as schema
fallback only when `catalog` is not being overridden. When browsing another
catalog (`catalog="main"`), the base URI's schema is omitted so the initial
namespace handshake succeeds regardless of whether that schema exists in the
target catalog.
3. **Unit tests updated in `test_databricks.py`**:
Verified both unconfigured catalog omission and catalog override schema
isolation.
@sadpandajoe, ready for re-review when convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
