FrancescoCastaldi commented on PR #43695: URL: https://github.com/apache/superset/pull/43695#issuecomment-6166527583
Follow-up update in commit `1c2d9f83b5`: - In `DatabricksNativeEngineSpec.adjust_engine_params`, updated query parameter handling to mutate via `query_dict = dict(uri.query)` and `uri.set(query=query_dict)`. When `catalog` is overridden without a `schema`, stale `schema` query parameters are now explicitly purged from the URL query dict as well as from `connect_args`. - Shortened the docstring in `test_databricks.py` to 79 characters, well within the 88-column Ruff limit. - Added a unit test verifying that starting from a URI with `?catalog=main&schema=finance&http_path=...`, calling `adjust_engine_params` with `catalog="other"` drops `schema` from both the URL query and `connect_args`. All review items on PR #43695 are addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
