geido commented on code in PR #45273:
URL: https://github.com/apache/superset/pull/45273#discussion_r4271952659
##########
superset/charts/data/api.py:
##########
@@ -563,18 +564,11 @@ def _process_data(query_data: Any) -> Any:
# their guest token has been granted "can view query on
Dashboard",
# mirroring the permission the frontend uses to expose the
# "View query" action. Stacktraces and driver errors stay
redacted
- # regardless, as those leak details of the deployment itself.
- can_view_query = security_manager.can_access(
- "can_view_query", "Dashboard"
- )
- for query in queries:
- if not can_view_query:
- query.pop("query", None)
- query.pop("stacktrace", None)
- if query.get("error"):
- query["error"] = sanitize_error_message(
- query["error"], required=sanitize_required
- )
+ # regardless, as those leak details of the deployment itself.
The
+ # same helper redacts the ``/datasource/samples`` (Drill to
+ # detail) response so the two guest-facing endpoints cannot
+ # diverge.
+ redact_sensitive_query_fields(queries,
required=sanitize_required)
Review Comment:
Good call — dropped the guard and the unused import; bare
`redact_sensitive_query_fields(queries)` now (fb5e113).
##########
tests/unit_tests/views/datasource/views_test.py:
##########
@@ -888,6 +888,36 @@ def test_samples_proceeds_for_supported_datasource_type(
view.json_response.assert_called_once_with({"result": {"rows": []}})
+@patch("superset.views.datasource.views.redact_sensitive_query_fields")
Review Comment:
Agreed — replaced it with a real-helper test against a guest without
`can_view_query`, asserting `query`/`stacktrace` are actually stripped
(fb5e113).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
