fitzee commented on PR #44730: URL: https://github.com/apache/superset/pull/44730#issuecomment-6181439054
Continued this in #45311 after the author's handoff, preserving the original commits. I cannot push to this fork from my account. The continuation updates to current master, fixes Actual Values without GROUPING SETS (including the grand-total corner), restores set-based metric lookup, and covers both layouts across all four value modes and both data paths. Charts unit tests: 374 passed, 2 xfailed; changed-file pre-commit checks pass. The two missing Actual Values cases fail against the unfinished implementation. #45311 explicitly depends on #44657 and remains draft until that browser change lands. This PR has been left open for maintainers to decide how to consolidate the work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
